Common workflow principle
The document should reflect why goods are moving. Applicable situations and compliance requirements can differ, so the business should verify the specific use case.
Preserve user intent
When a user enters through Create Delivery Challan, the document type should default accordingly. Conversion to sale should require an explicit action.
Maintain a clear trail
Use a separate series where appropriate, record party and items correctly, and preserve the later conversion or return outcome.